Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier): move logic to function #2121

Merged

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

Copy link

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.35%. Comparing base (e3165c4) to head (975ff5a).
Report is 500 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2121       +/-   ##
===========================================
+ Coverage   40.10%   69.35%   +29.25%     
===========================================
  Files          26      108       +82     
  Lines        1895    13970    +12075     
  Branches     1895    13970    +12075     
===========================================
+ Hits          760     9689     +8929     
- Misses       1100     3874     +2774     
- Partials       35      407      +372     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@dorimedini-starkware dorimedini-starkware force-pushed the 11-17-refactor_blockifier_move_logic_to_function branch from 7a27e86 to 65e10b3 Compare November 18, 2024 09:31
Copy link

Artifacts upload triggered. View details here

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 11-17-refactor_blockifier_move_logic_to_function branch from 65e10b3 to 975ff5a Compare November 19, 2024 09:54
Copy link

Artifacts upload triggered. View details here

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)

Copy link
Collaborator Author

dorimedini-starkware commented Nov 19, 2024

Merge activity

  • Nov 19, 7:52 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 19, 7:53 AM EST: A user merged this pull request with Graphite.

@dorimedini-starkware dorimedini-starkware merged commit 5b0e33c into main Nov 19, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants