-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(blockifier): update get class hash at resources #2130
refactor(blockifier): update get class hash at resources #2130
Conversation
Artifacts upload triggered. View details here |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2130 +/- ##
===========================================
+ Coverage 40.10% 69.34% +29.23%
===========================================
Files 26 108 +82
Lines 1895 13987 +12092
Branches 1895 13987 +12092
===========================================
+ Hits 760 9699 +8939
- Misses 1100 3878 +2778
- Partials 35 410 +375 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
c2e7f10
to
2ea675b
Compare
Artifacts upload triggered. View details here |
2ea675b
to
3af0799
Compare
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)
crates/blockifier/resources/versioned_constants_0_13_4.json
line 190 at r1 (raw file):
}, "get_class_hash_at_gas_cost": { "step_gas_cost": 89,
The minimum here is 100.
Code quote:
"step_gas_cost": 89,
3af0799
to
2ccdec2
Compare
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)
crates/blockifier/resources/versioned_constants_0_13_4.json
line 190 at r1 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
The minimum here is 100.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
2ccdec2
to
a5d28fd
Compare
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
a5d28fd
to
65c8707
Compare
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
No description provided.