Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier): update get class hash at resources #2130

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@AvivYossef-starkware AvivYossef-starkware marked this pull request as ready for review November 18, 2024 09:23
Copy link

Artifacts upload triggered. View details here

@AvivYossef-starkware AvivYossef-starkware removed the request for review from Yoni-Starkware November 18, 2024 09:28
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.34%. Comparing base (e3165c4) to head (65c8707).
Report is 524 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2130       +/-   ##
===========================================
+ Coverage   40.10%   69.34%   +29.23%     
===========================================
  Files          26      108       +82     
  Lines        1895    13987    +12092     
  Branches     1895    13987    +12092     
===========================================
+ Hits          760     9699     +8939     
- Misses       1100     3878     +2778     
- Partials       35      410      +375     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/update_get_class_hash_at_resources branch from c2e7f10 to 2ea675b Compare November 18, 2024 09:42
Copy link

Artifacts upload triggered. View details here

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/update_get_class_hash_at_resources branch from 2ea675b to 3af0799 Compare November 18, 2024 09:45
Copy link

Artifacts upload triggered. View details here

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)


crates/blockifier/resources/versioned_constants_0_13_4.json line 190 at r1 (raw file):

        },
        "get_class_hash_at_gas_cost": {
            "step_gas_cost": 89,

The minimum here is 100.

Code quote:

"step_gas_cost": 89,

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/update_get_class_hash_at_resources branch from 3af0799 to 2ccdec2 Compare November 18, 2024 10:54
Copy link

Artifacts upload triggered. View details here

Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)


crates/blockifier/resources/versioned_constants_0_13_4.json line 190 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

The minimum here is 100.

Done.

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/update_get_class_hash_at_resources branch from 2ccdec2 to a5d28fd Compare November 20, 2024 11:22
Copy link

Artifacts upload triggered. View details here

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/update_get_class_hash_at_resources branch from a5d28fd to 65c8707 Compare November 20, 2024 14:22
Copy link

Artifacts upload triggered. View details here

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware merged commit 065522d into main Nov 21, 2024
12 checks passed
@AvivYossef-starkware AvivYossef-starkware deleted the aviv/update_get_class_hash_at_resources branch November 21, 2024 06:13
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants