Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(network): discovery performs kad queries even if not connected to bootstrap #2142

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

ShahakShama
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 3 lines in your changes missing coverage. Please review.

Project coverage is 34.06%. Comparing base (e3165c4) to head (b15c119).
Report is 634 commits behind head on main.

Files with missing lines Patch % Lines
crates/papyrus_network/src/discovery/mod.rs 94.23% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2142      +/-   ##
==========================================
- Coverage   40.10%   34.06%   -6.05%     
==========================================
  Files          26       58      +32     
  Lines        1895     4947    +3052     
  Branches     1895     4947    +3052     
==========================================
+ Hits          760     1685     +925     
- Misses       1100     3204    +2104     
- Partials       35       58      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eitanm-starkware eitanm-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AlonLStarkWare and @ShahakShama)


crates/papyrus_network/src/discovery/discovery_test.rs line 237 at r1 (raw file):

}

#[tokio::test]

add test to check positive flow of added code. ie check that kad queries without bootstrap connected

@ShahakShama ShahakShama force-pushed the shahak/discovery_bootstrap_disconnect_bugfix branch from 2f361a8 to b15c119 Compare November 21, 2024 10:45
Copy link
Contributor Author

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @AlonLStarkWare and @eitanm-starkware)


crates/papyrus_network/src/discovery/discovery_test.rs line 237 at r1 (raw file):

Previously, eitanm-starkware wrote…

add test to check positive flow of added code. ie check that kad queries without bootstrap connected

Done.

Copy link
Contributor

@eitanm-starkware eitanm-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @AlonLStarkWare)

Copy link
Contributor

@eitanm-starkware eitanm-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AlonLStarkWare)

@ShahakShama ShahakShama merged commit 5623a90 into main Dec 1, 2024
17 checks passed
@ShahakShama ShahakShama deleted the shahak/discovery_bootstrap_disconnect_bugfix branch December 1, 2024 08:06
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants