-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(network): discovery performs kad queries even if not connected to bootstrap #2142
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2142 +/- ##
==========================================
- Coverage 40.10% 34.06% -6.05%
==========================================
Files 26 58 +32
Lines 1895 4947 +3052
Branches 1895 4947 +3052
==========================================
+ Hits 760 1685 +925
- Misses 1100 3204 +2104
- Partials 35 58 +23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AlonLStarkWare and @ShahakShama)
crates/papyrus_network/src/discovery/discovery_test.rs
line 237 at r1 (raw file):
} #[tokio::test]
add test to check positive flow of added code. ie check that kad queries without bootstrap connected
2f361a8
to
b15c119
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @AlonLStarkWare and @eitanm-starkware)
crates/papyrus_network/src/discovery/discovery_test.rs
line 237 at r1 (raw file):
Previously, eitanm-starkware wrote…
add test to check positive flow of added code. ie check that kad queries without bootstrap connected
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @AlonLStarkWare)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AlonLStarkWare)
No description provided.