Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(l1-provider): build l1 provider starter #2152

Conversation

MohammadNassar1
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@MohammadNassar1 MohammadNassar1 changed the base branch from main to mohammad/l1-provider/infra/l1-provider-types/impl-communication November 18, 2024 16:40
Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 77.10%. Comparing base (fe4423a) to head (a7f231f).

Files with missing lines Patch % Lines
...net_l1_provider_starter/src/l1_provider_starter.rs 0.00% 25 Missing ⚠️
crates/starknet_l1_provider_starter/src/config.rs 0.00% 12 Missing ⚠️
Additional details and impacted files
@@                                         Coverage Diff                                         @@
##           mohammad/l1-provider/infra/l1-provider-types/impl-communication    #2152      +/-   ##
===================================================================================================
- Coverage                                                            77.17%   77.10%   -0.08%     
===================================================================================================
  Files                                                                  386      388       +2     
  Lines                                                                40308    40345      +37     
  Branches                                                             40308    40345      +37     
===================================================================================================
- Hits                                                                 31108    31107       -1     
- Misses                                                                6910     6947      +37     
- Partials                                                              2290     2291       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@MohammadNassar1 MohammadNassar1 force-pushed the mohammad/l1-provider/infra/build-l1-provider-starter branch from 8882b4a to a7f231f Compare November 19, 2024 08:24
Copy link

Artifacts upload triggered. View details here

Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.371 ms 34.475 ms 34.593 ms]
change: [+1.8239% +2.1503% +2.5144%] (p = 0.00 < 0.05)
Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high severe

full_committer_flow performance regressed!
full_committer_flow time: [29.780 ms 29.883 ms 30.009 ms]
change: [+1.3547% +1.7362% +2.1930%] (p = 0.00 < 0.05)
Performance has regressed.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe

@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants