Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add testing feature, use automock only as test #2159

Merged
merged 1 commit into from
Nov 19, 2024
Merged

chore: add testing feature, use automock only as test #2159

merged 1 commit into from
Nov 19, 2024

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Nov 18, 2024 •
edited
Loading

commit-id:c208af25

This was referenced Nov 18, 2024
Closed
Merged
@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.23%. Comparing base (e3165c4) to head (d5fc805).
Report is 505 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_gateway_types/src/communication.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2159       +/-   ##
===========================================
+ Coverage   40.10%   77.23%   +37.12%     
===========================================
  Files          26      385      +359     
  Lines        1895    40404    +38509     
  Branches     1895    40404    +38509     
===========================================
+ Hits          760    31206    +30446     
- Misses       1100     6905     +5805     
- Partials       35     2293     +2258

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

dafnamatsry
dafnamatsry approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from spr/main/d05770a1 to main November 19, 2024 10:49
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

Itay-Tsabary-Starkware
Itay-Tsabary-Starkware commented Nov 19, 2024
View reviewed changes
Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

Itay-Tsabary-Starkware
Itay-Tsabary-Starkware commented Nov 19, 2024
View reviewed changes
Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware merged commit 2a4d3de into main Nov 19, 2024
21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dafnamatsry dafnamatsry dafnamatsry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Itay-Tsabary-Starkware @reviewable-StarkWare @dafnamatsry