Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(blockifier): replace class revert #2180

Merged
merged 1 commit into from
Nov 21, 2024
Merged

test(blockifier): replace class revert #2180

merged 1 commit into from
Nov 21, 2024

Conversation

AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@AvivYossef-starkware AvivYossef-starkware marked this pull request as ready for review November 19, 2024 14:11
@AvivYossef-starkware Graphite App
Copy link
Contributor Author

AvivYossef-starkware commented Nov 19, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.88%. Comparing base (e3165c4) to head (f316bbf).
Report is 546 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2180       +/-   ##
===========================================
+ Coverage   40.10%   68.88%   +28.77%     
===========================================
  Files          26      109       +83     
  Lines        1895    13895    +12000     
  Branches     1895    13895    +12000     
===========================================
+ Hits          760     9571     +8811     
- Misses       1100     3915     +2815     
- Partials       35      409      +374

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/test_replace_class_revert branch from fc5c984 to 3fbcef3 Compare November 20, 2024 14:31
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/test_replace_class_revert branch from 3fbcef3 to d364c56 Compare November 20, 2024 14:34
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/test_replace_class_revert branch from d364c56 to abddef2 Compare November 20, 2024 14:51
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/test_replace_class_revert branch from abddef2 to 9dad0c0 Compare November 21, 2024 06:21
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

Yoni-Starkware
Yoni-Starkware approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/test_replace_class_revert branch from 9dad0c0 to 169a57d Compare November 21, 2024 08:42
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

Yoni-Starkware
Yoni-Starkware approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware
test(blockifier): replace class revert
f316bbf 
test(blockifier): replace class revert
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/test_replace_class_revert branch from 169a57d to f316bbf Compare November 21, 2024 11:07
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

Yoni-Starkware
Yoni-Starkware approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware merged commit 58fa2e6 into main Nov 21, 2024
13 checks passed
@AvivYossef-starkware AvivYossef-starkware deleted the aviv/test_replace_class_revert branch November 21, 2024 12:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Yoni-Starkware Yoni-Starkware Yoni-Starkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AvivYossef-starkware @reviewable-StarkWare @Yoni-Starkware