feat(batcher): use the use_kzg_da flag in batcher block builder

[ArniStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ArniStarkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(batcher): use the use_kzg_da flag in batcher block builder #2226 👈 (View in Graphite)
• chore(batcher): add use_kzg_da flag to propose block input #2219
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 5.17%. Comparing base (697d9f8) to head (ff7c198).

Files with missing lines	Patch %	Lines
crates/starknet_batcher/src/block_builder.rs	0.00%	2 Missing ⚠️

Additional details and impacted files

@@                                   Coverage Diff                                    @@
##           arni/batcher/propose_block_input/use_kzg_da/add_value   #2226      +/-   ##
========================================================================================
- Coverage                                                  12.90%   5.17%   -7.74%     
========================================================================================
  Files                                                        189     146      -43     
  Lines                                                      23952   16962    -6990     
  Branches                                                   23952   16962    -6990     
========================================================================================
- Hits                                                        3092     877    -2215     
+ Misses                                                     20506   16011    -4495     
+ Partials                                                     354      74     -280     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[alonh5]

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @Yael-Starkware)

---

crates/starknet_batcher/src/proposal_manager.rs line 68 at r1 (raw file):

        &mut self,
        height: BlockNumber,
        use_kzg_da: bool,

Consider bundling the fields into a struct, that way, you could also remove the clippy override. It will be even more important and convenient when adding the next fields.

[Yael-Starkware]

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @alonh5)

---

crates/starknet_batcher/src/proposal_manager.rs line 68 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Consider bundling the fields into a struct, that way, you could also remove the clippy override. It will be even more important and convenient when adding the next fields.

maybe a BlockInfo struct should be passed here.

[ArniStarkware]

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @dafnamatsry)

---

crates/starknet_batcher/src/proposal_manager.rs line 68 at r1 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

maybe a BlockInfo struct should be passed here.

See #2231 towards that goal.

[ArniStarkware]

Closing this PR, as a more end-to-end approach was taken. See #2238