feat(blockifier): disallow contract addresses less than 16

[nimrod-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[nimrod-starkware]

python side PR

Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on @dorimedini-starkware and @Yoni-Starkware)

[github-actions]

Artifacts upload workflows:

• Started at 2024-11-24T15:21:52Z
• Started at 2024-11-24T16:08:23Z

[codecov]

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.44%. Comparing base (e3165c4) to head (43443da).
Report is 575 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/starknet_api/src/core.rs	66.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2252       +/-   ##
===========================================
+ Coverage   40.10%   65.44%   +25.34%     
===========================================
  Files          26      152      +126     
  Lines        1895    18292    +16397     
  Branches     1895    18292    +16397     
===========================================
+ Hits          760    11972    +11212     
- Misses       1100     5569     +4469     
- Partials       35      751      +716     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[dorimedini-starkware]

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @nimrod-starkware and @Yoni-Starkware)

---

crates/blockifier/src/execution/syscalls/syscall_tests/get_block_hash.rs line 10 at r1 (raw file):

use test_case::test_case;

use crate::abi::constants::{self, BLOCK_HASH_CONTRACT_ADDRESS};

delete (if no one else uses constants::<something> in this file), or revert and write constants::BLOCK_HASH_CONTRACT_ADDRESS instead of BLOCK_HASH_CONTRACT_ADDRESS

Code quote:

self

---

crates/starknet_api/src/core.rs line 162 at r1 (raw file):

        Ok(Self(PatriciaKey::try_from(hash)?))
    }
}

not a good place to check: 0x1 is a valid contract address (block hash contract), it's just not deployable.
I think this needs to be checked explicitly during execution of deployment (syscall, or DEPLOY_ACCOUNT tx).
@Yoni-Starkware thoughts?

Code quote:

impl TryFrom<StarkHash> for ContractAddress {
    type Error = StarknetApiError;
    fn try_from(hash: StarkHash) -> Result<Self, Self::Error> {
        if hash <= MAX_RESERVED_CONTRACT_ADDRESS.into() {
            return Err(Self::Error::ReservedContractAddress(hash));
        }
        Ok(Self(PatriciaKey::try_from(hash)?))
    }
}

---

crates/blockifier/resources/versioned_constants_0_13_4.json line 242 at r1 (raw file):

                    "pedersen_builtin": 7,
                    "range_check_builtin": 22
                },

where do these numbers come from? how are they generated?
also, what about DEPLOY_ACCOUNT? it doesn't use the syscall?

Code quote:

                "n_steps": 1158,
                "builtin_instance_counter": {
                    "pedersen_builtin": 7,
                    "range_check_builtin": 22
                },

[Yoni-Starkware]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dorimedini-starkware and @nimrod-starkware)

---

crates/starknet_api/src/core.rs line 162 at r1 (raw file):

Previously, dorimedini-starkware wrote…

not a good place to check: 0x1 is a valid contract address (block hash contract), it's just not deployable.
I think this needs to be checked explicitly during execution of deployment (syscall, or DEPLOY_ACCOUNT tx).
@Yoni-Starkware thoughts?

Right.