Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier): remove unnecessary wrapper for library call #2258

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

Yoni-Starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Nov 25, 2024

Artifacts upload workflows:

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.62%. Comparing base (e3165c4) to head (d85fa3d).
Report is 565 commits behind head on main.

Files with missing lines Patch % Lines
crates/blockifier/src/execution/syscalls/mod.rs 77.27% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2258       +/-   ##
===========================================
+ Coverage   40.10%   68.62%   +28.52%     
===========================================
  Files          26      109       +83     
  Lines        1895    13942    +12047     
  Branches     1895    13942    +12047     
===========================================
+ Hits          760     9568     +8808     
- Misses       1100     3964     +2864     
- Partials       35      410      +375     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Yoni-Starkware Yoni-Starkware force-pushed the yoni/syscall-handler/clean-libcall branch from 0b9a207 to d85fa3d Compare November 25, 2024 08:35
Copy link
Contributor

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@Yoni-Starkware Yoni-Starkware merged commit d9f7c62 into main Nov 25, 2024
13 checks passed
@Yoni-Starkware Yoni-Starkware deleted the yoni/syscall-handler/clean-libcall branch November 25, 2024 10:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants