-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(blockifier): share execute_inner_call code #2263
refactor(blockifier): share execute_inner_call code #2263
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2263 +/- ##
===========================================
+ Coverage 40.10% 68.65% +28.55%
===========================================
Files 26 108 +82
Lines 1895 13891 +11996
Branches 1895 13891 +11996
===========================================
+ Hits 760 9537 +8777
- Misses 1100 3944 +2844
- Partials 35 410 +375 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
6ae3f68
to
761a97e
Compare
0ba28bb
to
19260eb
Compare
761a97e
to
0aa3e21
Compare
19260eb
to
a447ab4
Compare
0aa3e21
to
f3f714b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @Yoni-Starkware)
crates/blockifier/src/execution/syscalls/syscall_base.rs
line 102 at r2 (raw file):
} pub fn execute_inner_call(
will this be used in the native syscall struct?
Code quote:
pub fn execute_inner_call(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @dorimedini-starkware)
crates/blockifier/src/execution/syscalls/syscall_base.rs
line 102 at r2 (raw file):
Previously, amosStarkware wrote…
will this be used in the native syscall struct?
Yes, next PR.
It contains revert-handling code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
f3f714b
to
6a23b72
Compare
No description provided.