Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier): share execute_inner_call code #2263

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

Yoni-Starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.65%. Comparing base (e3165c4) to head (6a23b72).
Report is 573 commits behind head on main.

Files with missing lines Patch % Lines
.../blockifier/src/execution/syscalls/syscall_base.rs 93.75% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2263       +/-   ##
===========================================
+ Coverage   40.10%   68.65%   +28.55%     
===========================================
  Files          26      108       +82     
  Lines        1895    13891    +11996     
  Branches     1895    13891    +11996     
===========================================
+ Hits          760     9537     +8777     
- Misses       1100     3944     +2844     
- Partials       35      410      +375     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Yoni-Starkware Yoni-Starkware force-pushed the yoni/syscall-handler/exec-inner-call-base branch from 6ae3f68 to 761a97e Compare November 25, 2024 09:23
@Yoni-Starkware Yoni-Starkware force-pushed the yoni/syscall-handler/mv-get-block-hash-to-base branch from 0ba28bb to 19260eb Compare November 25, 2024 11:12
@Yoni-Starkware Yoni-Starkware force-pushed the yoni/syscall-handler/exec-inner-call-base branch from 761a97e to 0aa3e21 Compare November 25, 2024 11:12
@Yoni-Starkware Yoni-Starkware force-pushed the yoni/syscall-handler/mv-get-block-hash-to-base branch from 19260eb to a447ab4 Compare November 25, 2024 11:30
@Yoni-Starkware Yoni-Starkware force-pushed the yoni/syscall-handler/exec-inner-call-base branch from 0aa3e21 to f3f714b Compare November 25, 2024 11:31
Copy link
Contributor

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @Yoni-Starkware)


crates/blockifier/src/execution/syscalls/syscall_base.rs line 102 at r2 (raw file):

    }

    pub fn execute_inner_call(

will this be used in the native syscall struct?

Code quote:

pub fn execute_inner_call(

Copy link
Collaborator Author

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @dorimedini-starkware)


crates/blockifier/src/execution/syscalls/syscall_base.rs line 102 at r2 (raw file):

Previously, amosStarkware wrote…

will this be used in the native syscall struct?

Yes, next PR.
It contains revert-handling code.

Copy link
Contributor

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@Yoni-Starkware Yoni-Starkware force-pushed the yoni/syscall-handler/exec-inner-call-base branch from f3f714b to 6a23b72 Compare November 25, 2024 13:26
@Yoni-Starkware Yoni-Starkware changed the base branch from yoni/syscall-handler/mv-get-block-hash-to-base to main November 25, 2024 13:26
@Yoni-Starkware Yoni-Starkware merged commit ee525e1 into main Nov 25, 2024
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants