refactor(blockifier): see if LC fix worked

[meship-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2024-11-25T15:17:24Z
• Started at 2024-11-26T07:50:48Z
• Started at 2024-11-26T12:43:17Z

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.91%. Comparing base (e3165c4) to head (e2fb0e4).
Report is 641 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2274       +/-   ##
===========================================
+ Coverage   40.10%   76.91%   +36.81%     
===========================================
  Files          26      386      +360     
  Lines        1895    40523    +38628     
  Branches     1895    40523    +38628     
===========================================
+ Hits          760    31169    +30409     
- Misses       1100     7056     +5956     
- Partials       35     2298     +2263     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.413 ms 34.504 ms 34.609 ms]
change: [-4.0650% -2.5060% -1.0857%] (p = 0.00 < 0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
2 (2.00%) high mild
7 (7.00%) high severe

[meship-starkware]

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion

---

crates/blockifier/src/execution/native/entry_point_execution.rs line 76 at r2 (raw file):

        //     // TODO(Yoni): temporary hack - this is probably a bug. Investigate and fix native.
        //     remaining_gas = syscall_handler.call.initial_gas;
        // } else {

LC fix should also fix this issue, right? If so, how can we test it?

Code quote:

    if remaining_gas > syscall_handler.base.call.initial_gas {
        // if remaining_gas - syscall_handler.call.initial_gas
        //     <= syscall_handler.context.gas_costs().entry_point_initial_budget
        // {
        //     // Revert the refund.
        //     // TODO(Yoni): temporary hack - this is probably a bug. Investigate and fix native.
        //     remaining_gas = syscall_handler.call.initial_gas;
        // } else {

[github-actions]

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [30.642 ms 30.704 ms 30.769 ms]
change: [+2.7810% +3.0297% +3.2933%] (p = 0.00 < 0.05)
Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild