Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_api): use lazylock to define query version base #2278

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ArniStarkware ArniStarkware marked this pull request as ready for review November 26, 2024 06:57
Copy link

Artifacts upload workflows:

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.61%. Comparing base (e3165c4) to head (31eeb8f).
Report is 587 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2278       +/-   ##
===========================================
+ Coverage   40.10%   76.61%   +36.50%     
===========================================
  Files          26      110       +84     
  Lines        1895    13930    +12035     
  Branches     1895    13930    +12035     
===========================================
+ Hits          760    10672     +9912     
- Misses       1100     2795     +1695     
- Partials       35      463      +428     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

@ArniStarkware ArniStarkware merged commit ed27bf0 into main Nov 26, 2024
16 checks passed
@ArniStarkware ArniStarkware deleted the arni/query_version_base/lazylock branch November 26, 2024 11:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants