Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): use infra utils dir in cairo compile #2284

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ArniStarkware ArniStarkware marked this pull request as ready for review November 26, 2024 09:50
Copy link

github-actions bot commented Nov 26, 2024

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (arni/cargo_manifest_dir/versioned_constants_test@4fab329). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/blockifier/src/test_utils/cairo_compile.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                 Coverage Diff                                 @@
##             arni/cargo_manifest_dir/versioned_constants_test    #2284   +/-   ##
===================================================================================
  Coverage                                                    ?   77.55%           
===================================================================================
  Files                                                       ?      389           
  Lines                                                       ?    41184           
  Branches                                                    ?    41184           
===================================================================================
  Hits                                                        ?    31942           
  Misses                                                      ?     6980           
  Partials                                                    ?     2262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware changed the title chore(blockifier): use the suggested test util for cargo manifest dir in cairo compile chore(blockifier): use infra utils dir in cairo compile Nov 26, 2024
@ArniStarkware ArniStarkware force-pushed the arni/cargo_manifest_dir/versioned_constants_test branch from 3d36600 to dc43bfc Compare November 26, 2024 15:07
@ArniStarkware ArniStarkware force-pushed the arni/cargo_manifest_dir/blockifier/cairo_compile branch from 37e9187 to fad502e Compare November 26, 2024 15:07
@ArniStarkware ArniStarkware force-pushed the arni/cargo_manifest_dir/versioned_constants_test branch from dc43bfc to 711f2bc Compare December 1, 2024 15:31
@ArniStarkware ArniStarkware force-pushed the arni/cargo_manifest_dir/blockifier/cairo_compile branch from fad502e to d8f7830 Compare December 1, 2024 15:31
@ArniStarkware ArniStarkware force-pushed the arni/cargo_manifest_dir/versioned_constants_test branch from 711f2bc to 56ca608 Compare December 3, 2024 16:02
@ArniStarkware ArniStarkware force-pushed the arni/cargo_manifest_dir/blockifier/cairo_compile branch from d8f7830 to 8bf9f76 Compare December 3, 2024 16:02
@ArniStarkware ArniStarkware force-pushed the arni/cargo_manifest_dir/versioned_constants_test branch from 56ca608 to e68a91e Compare December 9, 2024 08:58
@ArniStarkware
Copy link
Contributor Author

No longer relevant.

@ArniStarkware ArniStarkware deleted the arni/cargo_manifest_dir/blockifier/cairo_compile branch December 9, 2024 08:59
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants