refactor(starknet_api): remove duplicate definition of contract class

[AvivYossef-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[AvivYossef-starkware]

• refactor(starknet_api): remove duplicate definition of contract class #2298 👈 (View in Graphite)
• refactor(starknet_api): entry points by type field of sierra contact #2294
• refactor(starknet_api): add contract class version to sierra contract #2277
• refactor(starknet_api): rename contract class to sierra contract class #2276
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2024-11-27T08:14:22Z
• Started at 2024-11-27T09:43:21Z
• Started at 2024-11-27T13:08:27Z

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.82%. Comparing base (e3165c4) to head (6383cd0).
Report is 612 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2298       +/-   ##
===========================================
- Coverage   40.10%   27.82%   -12.29%     
===========================================
  Files          26      199      +173     
  Lines        1895    25435    +23540     
  Branches     1895    25435    +23540     
===========================================
+ Hits          760     7077     +6317     
- Misses       1100    17776    +16676     
- Partials       35      582      +547     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Yoni-Starkware]

Reviewed 8 of 12 files at r1, all commit messages.
Reviewable status: 8 of 12 files reviewed, 3 unresolved discussions (waiting on @AvivYossef-starkware)

---

crates/starknet_sierra_compile/src/utils.rs line 12 at r2 (raw file):

use starknet_api::state::{
    EntryPoint as StarknetApiEntryPoint,
    SierraContractClass as RpcContractClass,

Suggestion:

SierraContractClass as StarknetApiContractClass,

---

crates/papyrus_protobuf/src/converters/rpc_transaction.rs line 334 at r2 (raw file):

}

impl TryFrom<protobuf::Cairo1Class> for ContractClass {

@DvirYo-starkware are we okay with removing this?

Code quote:

impl TryFrom<protobuf::Cairo1Class> for ContractClass {

---

crates/starknet_gateway/src/stateless_transaction_validator_test.rs line 359 at r2 (raw file):

    #[case] expected_error: StatelessTransactionValidatorError,
) {
    use starknet_api::state::SierraContractClass;

Is this necessary?

Code quote:

use starknet_api::state::SierraContractClass;

[AvivYossef-starkware]

Reviewable status: 8 of 12 files reviewed, 3 unresolved discussions (waiting on @DvirYo-starkware and @Yoni-Starkware)

---

crates/papyrus_protobuf/src/converters/rpc_transaction.rs line 334 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

@DvirYo-starkware are we okay with removing this?

Dvir approves the PR as long as the tests pass.

---

crates/starknet_gateway/src/stateless_transaction_validator_test.rs line 359 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Is this necessary?

No

---

crates/starknet_sierra_compile/src/utils.rs line 12 at r2 (raw file):

use starknet_api::state::{
    EntryPoint as StarknetApiEntryPoint,
    SierraContractClass as RpcContractClass,

Done.

[Yoni-Starkware]

Reviewed 1 of 12 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status: 11 of 12 files reviewed, all discussions resolved

[Yoni-Starkware]

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

[AvivYossef-starkware]

Merge activity

• Nov 28, 2:53 AM EST: A user merged this pull request with Graphite.