Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sync): create state sync channels #2303

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

noamsp-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

noamsp-starkware commented Nov 27, 2024

Copy link

Artifacts upload workflows:

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.14%. Comparing base (e3165c4) to head (623d248).
Report is 608 commits behind head on main.

Files with missing lines Patch % Lines
...rates/starknet_sequencer_node/src/communication.rs 40.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2303       +/-   ##
===========================================
+ Coverage   40.10%   77.14%   +37.03%     
===========================================
  Files          26      386      +360     
  Lines        1895    40549    +38654     
  Branches     1895    40549    +38654     
===========================================
+ Hits          760    31281    +30521     
- Misses       1100     6958     +5858     
- Partials       35     2310     +2275     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noamsp-starkware noamsp-starkware marked this pull request as ready for review November 27, 2024 11:44
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)

@noamsp-starkware noamsp-starkware merged commit e5576a4 into main Nov 27, 2024
22 checks passed
@noamsp-starkware noamsp-starkware deleted the noam.s/create_state_sync_channels branch November 27, 2024 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants