Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(starknet_sequencer_infra): add tracing test #2332

Closed
wants to merge 1 commit into from
Closed

chore(starknet_sequencer_infra): add tracing test #2332

wants to merge 1 commit into from

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Nov 28, 2024 •
edited
Loading

This was referenced Nov 28, 2024
Closed
Closed
Merged
@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Artifacts upload workflows:

@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.59%. Comparing base (7967122) to head (e7a2141).

Additional details and impacted files 
@@                  Coverage Diff                  @@
##           spr/main/9ffe9fbe    #2332      +/-   ##
=====================================================
+ Coverage              77.55%   77.59%   +0.04%     
=====================================================
  Files                    388      388              
  Lines                  41126    41126              
  Branches               41126    41126              
=====================================================
+ Hits                   31895    31912      +17     
+ Misses                  6978     6961      -17     
  Partials                2253     2253

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the title chore(infra): add tracing test chore(starknet_sequencer_infra): add tracing test Dec 1, 2024
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware mentioned this pull request Dec 1, 2024
Open
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the spr/main/76d16e9a branch 2 times, most recently from 7bfe91f to 4a77ea6 Compare December 2, 2024 08:32
This was referenced Dec 2, 2024
Closed
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.979 ms 35.449 ms 36.003 ms]
change: [+1.0093% +2.4195% +3.8427%] (p = 0.00 < 0.05)
Performance has regressed.
Found 18 outliers among 100 measurements (18.00%)
6 (6.00%) high mild
12 (12.00%) high severe

lev-starkware
lev-starkware approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 4 files reviewed, all discussions resolved

lev-starkware
lev-starkware approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

lev-starkware
lev-starkware approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware mentioned this pull request Dec 3, 2024
Merged
@Itay-Tsabary-Starkware
Copy link
Contributor Author

✓ Commit merged in pull request #2424

@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lev-starkware lev-starkware lev-starkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Itay-Tsabary-Starkware @reviewable-StarkWare @lev-starkware