-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(native_blockifier): support receiving L1 Data Gas #2343
feat(native_blockifier): support receiving L1 Data Gas #2343
Conversation
70e441d
to
db02f22
Compare
db02f22
to
961666a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2343 +/- ##
===========================================
+ Coverage 40.10% 52.10% +11.99%
===========================================
Files 26 188 +162
Lines 1895 21774 +19879
Branches 1895 21774 +19879
===========================================
+ Hits 760 11345 +10585
- Misses 1100 9651 +8551
- Partials 35 778 +743 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @TzahiTaub)
a discussion (no related file):
py side PR?
961666a
to
ce7d6bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @TzahiTaub)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aner-starkware)
crates/native_blockifier/src/py_transaction.rs
line 42 at r2 (raw file):
PyResource::L1Gas => Resource::L1Gas, PyResource::L1DataGas => Resource::L1DataGas, PyResource::L2Gas => Resource::L2Gas,
Moved to be consistent with the order in the enum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @dorimedini-starkware)
a discussion (no related file):
Previously, dorimedini-starkware wrote…
py side PR?
https://reviewable.io/reviews/starkware-industries/starkware/36348#-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)
No description provided.