fix(blockifier,committer_cli,papyrus_network,papyrus_storage,starknet…

[dorimedini-starkware]

…_client): clippy

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2024-11-28T15:39:21Z
• Started at 2024-11-28T15:40:54Z

[nimrod-starkware]

Reviewable status: 0 of 29 files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

[ArniStarkware]

Reviewed 9 of 29 files at r1.
Reviewable status: 9 of 29 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/blockifier/src/execution/syscalls/hint_processor.rs line 190 at r1 (raw file):

/// Error codes returned by Cairo 1.0 code.
// "Out of gas";

Does this work?

Suggestion:

/// Error codes returned by Cairo 1.0 code.


// "Out of gas";

---

crates/blockifier/src/execution/entry_point.rs line 346 at r1 (raw file):

        // Logically, we update remaining steps to `max(0, remaining_steps - steps_to_subtract)`.
        let remaining_steps = self.n_remaining_steps();
        let new_remaining_steps = remaining_steps.saturating_sub(steps_to_subtract);

Uch... saturating_sub is indeed exactly that - but I would argue it is less readable.

Code quote:

let new_remaining_steps = remaining_steps.saturating_sub(steps_to_subtract);

---

crates/blockifier/src/fee/gas_usage.rs line 68 at r1 (raw file):

        discount += eth_gas_constants::GAS_PER_MEMORY_WORD - fee_balance_value_cost;

        let gas = naive_cost.saturating_sub(discount);

Suggestion:

   // Cost must be non-negative after discount.
   let gas = naive_cost.saturating_sub(discount);

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.38%. Comparing base (e3165c4) to head (6c2bab5).
Report is 639 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2355       +/-   ##
===========================================
+ Coverage   40.10%   65.38%   +25.28%     
===========================================
  Files          26      226      +200     
  Lines        1895    24499    +22604     
  Branches     1895    24499    +22604     
===========================================
+ Hits          760    16019    +15259     
- Misses       1100     7341     +6241     
- Partials       35     1139     +1104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ArniStarkware]

Reviewed 16 of 29 files at r1, all commit messages.
Reviewable status: 25 of 29 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/papyrus_test_utils/src/lib.rs line 365 at r1 (raw file):

//////////////////////////////////////////////////////////////////////////
// /// EXTERNAL FUNCTIONS - REMOVE DUPLICATIONS
//////////////////////////////////////////////////////////////////////////

hu?

Code quote:

//////////////////////////////////////////////////////////////////////////
// /// EXTERNAL FUNCTIONS - REMOVE DUPLICATIONS
//////////////////////////////////////////////////////////////////////////

[ArniStarkware]

crates/starknet_api/src/core.rs line 90 at r1 (raw file):

/// [DeclareTransaction](`crate::transaction::DeclareTransaction`), and
/// [BlockHeader](`crate::block::BlockHeader`).
// The block hash table is stored in address 0x1,

Creating a discussion to get a link.

Code quote:

/// The address of a contract, used for example in [StateDiff](`crate::state::StateDiff`),
/// [DeclareTransaction](`crate::transaction::DeclareTransaction`), and
/// [BlockHeader](`crate::block::BlockHeader`).
// The block hash table is stored in address 0x1,

[ArniStarkware]

Reviewable status: 25 of 29 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)

---

a discussion (no related file):
There is one use in the repo of:
is_none_or

It can be replaced with:

match self.current_height {
            Some(h) => h < height,
            None => true,
        }

Use this to fix if it is blocking.

[ArniStarkware]

Reviewed 2 of 29 files at r1.
Reviewable status: 27 of 29 files reviewed, 3 unresolved discussions (waiting on @dorimedini-starkware)

---

crates/papyrus_test_utils/src/lib.rs line 365 at r1 (raw file):

//////////////////////////////////////////////////////////////////////////
// /// EXTERNAL FUNCTIONS - REMOVE DUPLICATIONS
//////////////////////////////////////////////////////////////////////////

This is how other headlines in this file are set.

Suggestion:

//////////////////////////////////////////////////////////////////////////
// EXTERNAL FUNCTIONS - REMOVE DUPLICATIONS
//////////////////////////////////////////////////////////////////////////

[ArniStarkware]

If we plan to revive this PR, it needs a restack.

[ArniStarkware]

Replaced with #2365

[ArniStarkware]

Please delete this PR. #2371 was merged.

Reviewable status: 27 of 29 files reviewed, 4 unresolved discussions (waiting on @dorimedini-starkware)