-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(blockifier): convert Sierra gas to L1 gas if in L1 gas mode #2451
Conversation
Artifacts upload workflows: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2451 +/- ##
===========================================
+ Coverage 40.10% 79.51% +39.40%
===========================================
Files 26 102 +76
Lines 1895 13715 +11820
Branches 1895 13715 +11820
===========================================
+ Hits 760 10905 +10145
- Misses 1100 2342 +1242
- Partials 35 468 +433 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/starknet_api/src/execution_resources.rs
line 166 at r1 (raw file):
/// Panics on overflow. pub fn to_discounted_l1_gas(&self, gas_prices: &GasPriceVector) -> GasAmount { // TODO(Yoni, 10/12/2024): convert L2 gas as well.
Monday https://starkware.monday.com/boards/6987445459/pulses/7981858261
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)
crates/starknet_api/src/execution_resources.rs
line 166 at r1 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Monday https://starkware.monday.com/boards/6987445459/pulses/7981858261
can you add this block?
if self.l2_gas > 0 { todo!(); }
0b0f256
to
059a75a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)
No description provided.