Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): convert Sierra gas to L1 gas if in L1 gas mode #2451

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

Yoni-Starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Dec 4, 2024

Artifacts upload workflows:

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.51%. Comparing base (e3165c4) to head (059a75a).
Report is 695 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_api/src/execution_resources.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2451       +/-   ##
===========================================
+ Coverage   40.10%   79.51%   +39.40%     
===========================================
  Files          26      102       +76     
  Lines        1895    13715    +11820     
  Branches     1895    13715    +11820     
===========================================
+ Hits          760    10905    +10145     
- Misses       1100     2342     +1242     
- Partials       35      468      +433     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator Author

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/starknet_api/src/execution_resources.rs line 166 at r1 (raw file):

    /// Panics on overflow.
    pub fn to_discounted_l1_gas(&self, gas_prices: &GasPriceVector) -> GasAmount {
        // TODO(Yoni, 10/12/2024): convert L2 gas as well.

Monday https://starkware.monday.com/boards/6987445459/pulses/7981858261

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)


crates/starknet_api/src/execution_resources.rs line 166 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Monday https://starkware.monday.com/boards/6987445459/pulses/7981858261

can you add this block?

if self.l2_gas > 0 { todo!(); }

@Yoni-Starkware Yoni-Starkware force-pushed the yoni/sierra-gas/convert-to-l1 branch from 0b0f256 to 059a75a Compare December 4, 2024 15:15
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

@Yoni-Starkware Yoni-Starkware merged commit af955af into main Dec 4, 2024
16 checks passed
@Yoni-Starkware Yoni-Starkware deleted the yoni/sierra-gas/convert-to-l1 branch December 4, 2024 15:51
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants