Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_sierra_compile): move env var from run time to compile… #2454

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Dec 4, 2024

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.43%. Comparing base (e3165c4) to head (ba2756e).
Report is 708 commits behind head on main.

Files with missing lines Patch % Lines
crates/blockifier/src/test_utils/cairo_compile.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2454       +/-   ##
===========================================
+ Coverage   40.10%   77.43%   +37.33%     
===========================================
  Files          26      389      +363     
  Lines        1895    41355    +39460     
  Branches     1895    41355    +39460     
===========================================
+ Hits          760    32025    +31265     
- Misses       1100     7064     +5964     
- Partials       35     2266     +2231     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the title chore(starknet_sierra_compile): move env var from run time to compile time chore(starknet_sierra_compile): move env var from run time to compile… Dec 5, 2024
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from spr/main/80a7265d to main December 5, 2024 11:04
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware merged commit fa2439b into main Dec 5, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants