-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(consensus): remove the tx_hash from transactionBatch #2459
base: main
Are you sure you want to change the base?
Conversation
c461854
to
d90d875
Compare
cab7be5
to
39614b8
Compare
d90d875
to
3f229bf
Compare
39614b8
to
237b239
Compare
3f229bf
to
a23e3cf
Compare
237b239
to
443acfa
Compare
a23e3cf
to
3a3d2bf
Compare
443acfa
to
ee60997
Compare
3a3d2bf
to
0a4b210
Compare
ee60997
to
8f0301e
Compare
0a4b210
to
f377d1f
Compare
8f0301e
to
e10c2a4
Compare
f377d1f
to
c3a2d27
Compare
c3a2d27
to
46f5219
Compare
e10c2a4
to
99a88ed
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## yael/convert_transaction_to_executable_transaction #2459 +/- ##
=======================================================================================
+ Coverage 18.44% 32.92% +14.47%
=======================================================================================
Files 225 119 -106
Lines 30735 14144 -16591
Branches 30735 14144 -16591
=======================================================================================
- Hits 5670 4657 -1013
+ Misses 24632 8928 -15704
- Partials 433 559 +126 ☔ View full report in Codecov by Sentry. |
46f5219
to
2eb8a6e
Compare
99a88ed
to
5f72901
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 6 files at r1, 5 of 7 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5, @matan-starkware, and @Yael-Starkware)
crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs
line 468 at r4 (raw file):
transactions.push(tx.into()); } debug!("Broadcasting proposal content: {transaction_hashes:?}");
I think this debug (and the extraction of the hashes right above it) was here before I added the hashes to the transaction batch. It may be better to leave it here.
5f72901
to
7558332
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5, @guy-starkware, and @matan-starkware)
crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs
line 468 at r4 (raw file):
Previously, guy-starkware wrote…
I think this debug (and the extraction of the hashes right above it) was here before I added the hashes to the transaction batch. It may be better to leave it here.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 6 files at r1, 5 of 7 files at r3, 1 of 2 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware and @matan-starkware)
c2a12a3
to
6da7a51
Compare
7558332
to
28cf4d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware and @matan-starkware)
fd4efc9
to
0b267dd
Compare
28cf4d2
to
3e78cac
Compare
0b267dd
to
42c5799
Compare
3e78cac
to
2f37611
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r8.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @matan-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 8 files at r7, 7 of 8 files at r8, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Yael-Starkware)
crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context_test.rs
line 61 at r8 (raw file):
static ref EXECUTABLE_TX_BATCH: Vec<ExecutableTransaction> = TX_BATCH.iter().map(|tx| (tx.clone(), &CHAIN_ID).try_into().unwrap()).collect(); }
Suggestion:
lazy_static! {
static ref TX_BATCH: Vec<Transaction> = (0..3).map(generate_invoke_tx).collect();
static ref EXECUTABLE_TX_BATCH: Vec<ExecutableTransaction> =
TX_BATCH.iter().map(|tx| (tx.clone(), &CHAIN_ID).try_into().unwrap()).collect();
}
crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs
line 401 at r8 (raw file):
let chain_id = self.chain_id.clone(); let handle = tokio::spawn({
Why add another scope?
Code quote:
let handle = tokio::spawn({
60f2f25
to
b1d2a08
Compare
b1d2a08
to
d04655f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 8 files reviewed, 2 unresolved discussions (waiting on @guy-starkware and @matan-starkware)
crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs
line 401 at r8 (raw file):
Previously, matan-starkware wrote…
Why add another scope?
was just left here by accident form the previous PR on stack.
anyway, deleted now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 8 files at r7, 1 of 8 files at r8, 2 of 2 files at r9, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)
No description provided.