Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(starknet_batcher): rename GetProposalResultError and remove the ProposalNotFound variant #2483

refactor(starknet_batcher): rename GetProposalResultError and remove …

372a1c5
Select commit
Loading
Failed to load commit list.
Merged

refactor(starknet_batcher): rename GetProposalResultError and remove the ProposalNotFound variant #2483

refactor(starknet_batcher): rename GetProposalResultError and remove …
372a1c5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 9, 2024 in 1s

57.15% (+17.05%) compared to e3165c4

View this Pull Request on Codecov

57.15% (+17.05%) compared to e3165c4

Details

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 57.15%. Comparing base (e3165c4) to head (372a1c5).
Report is 757 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_batcher/src/proposal_manager.rs 33.33% 5 Missing and 1 partial ⚠️
crates/starknet_batcher/src/batcher.rs 33.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2483       +/-   ##
===========================================
+ Coverage   40.10%   57.15%   +17.05%     
===========================================
  Files          26      156      +130     
  Lines        1895    18309    +16414     
  Branches     1895    18309    +16414     
===========================================
+ Hits          760    10465     +9705     
- Misses       1100     7378     +6278     
- Partials       35      466      +431     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.