Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(papyrus_p2p_sync): convert class tests to use run_test #2485

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ShahakShama
Copy link
Contributor

  • refactor(papyrus_p2p_sync): add random_header utility function
  • refactor(papyrus_p2p_sync): add_test receives query size instead of constant
  • refactor(papyrus_p2p_sync): run_test supports all data types
  • refactor(papyrus_p2p_sync): convert state diff tests to use run_test
  • refactor(papyrus_p2p_sync): convert class tests to use run_test

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@eitanm-starkware eitanm-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ShahakShama)


crates/papyrus_p2p_sync/src/client/class_test.rs line 138 at r2 (raw file):

            .boxed()
        })));
    }

we should have consistency with sending DataOrFin(None) on basic flow tests. in the statediff one it is sent at the end. albeit this doesn't impact the test so your choice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants