chore: unfixtate parity versions #2490
Conversation
|
This change is |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2490 +/- ##
===========================================
+ Coverage 40.10% 77.45% +37.34%
===========================================
Files 26 386 +360
Lines 1895 41429 +39534
Branches 1895 41429 +39534
===========================================
+ Hits 760 32088 +31328
- Misses 1100 7059 +5959
- Partials 35 2282 +2247 ☔ View full report in Codecov by Sentry. |
Itay-Tsabary-Starkware
force-pushed
the
spr/main/aa65d32b
branch
from
eb9194b to
cf9287c
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
Cargo.toml line 181 at r1 (raw file):
papyrus_test_utils = { path = "crates/papyrus_test_utils", version = "0.0.0" } parity-scale-codec = "=3.6" parity-scale-codec-derive = "=3.6"
Will this work? the = is what the udeps forced us to use, there was something at 3.6.10 that made udeps flip
Suggestion:
parity-scale-codec = "3.6"
parity-scale-codec-derive = "3.6"
Itay-Tsabary-Starkware
force-pushed
the
spr/main/aa65d32b
branch
2 times, most recently
from
1c0a681 to
58ddb83
Compare
commit-id:aa65d32b
Itay-Tsabary-Starkware
force-pushed
the
spr/main/aa65d32b
branch
from
58ddb83 to
5086fcf
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @giladchase)
Cargo.toml line 181 at r1 (raw file):
Previously, giladchase wrote…
Will this work? the
=is what the udeps forced us to use, there was something at 3.6.10 that made udeps flip
Seems so.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
No description provided.