Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_monitoring_endpoint): use run_until for querying liveness #2492

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Dec 5, 2024

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.52%. Comparing base (e3165c4) to head (f30297e).
Report is 765 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2492       +/-   ##
===========================================
+ Coverage   40.10%   77.52%   +37.42%     
===========================================
  Files          26      387      +361     
  Lines        1895    41395    +39500     
  Branches     1895    41395    +39500     
===========================================
+ Hits          760    32093    +31333     
- Misses       1100     7034     +5934     
- Partials       35     2268     +2233     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the spr/main/431dc874 branch 2 times, most recently from 18335dd to 311c01c Compare December 8, 2024 19:27
Copy link
Contributor

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware added this pull request to the merge queue Dec 9, 2024
@alonh5 alonh5 removed this pull request from the merge queue due to the queue being cleared Dec 9, 2024
commit-id:431dc874
Copy link

github-actions bot commented Dec 9, 2024

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.528 ms 34.855 ms 35.237 ms]
change: [+1.2041% +2.1513% +3.2545%] (p = 0.00 < 0.05)
Performance has regressed.
Found 14 outliers among 100 measurements (14.00%)
3 (3.00%) high mild
11 (11.00%) high severe

Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware merged commit 8cd7b38 into main Dec 9, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants