refactor(consensus): remove next_message to ensure cancellation safety #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Dec 5, 2024
matan-starkware
force-pushed
the
matan/consensus/manager_start_height
branch
from
5d107fa to
890c09f
Compare
matan-starkware
force-pushed
the
matan/consensus/manager_remove_next_message
branch
from
f966260 to
bd405f2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2497 +/- ##
===========================================
- Coverage 40.10% 13.23% -26.88%
===========================================
Files 26 63 +37
Lines 1895 7738 +5843
Branches 1895 7738 +5843
===========================================
+ Hits 760 1024 +264
- Misses 1100 6677 +5577
- Partials 35 37 +2 ☔ View full report in Codecov by Sentry. |
asmaastarkware
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)
dan-starkware
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
matan-starkware
changed the base branch from
matan/consensus/manager_start_height
to
graphite-base/2497
Previously we could receive a message and then at the await point for continue_propagation or report_peer the select statement could complete another branch resulting in a dropped message.
matan-starkware
force-pushed
the
matan/consensus/manager_remove_next_message
branch
from
bd405f2 to
a838ea6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we could receive a message and then at the await point for continue_propagation or report_peer the select statement could complete another branch resulting in a dropped message.