Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): add ecdsa_gas_cost #2501

Conversation

Yonatan-Starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Dec 5, 2024

Artifacts upload workflows:

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.94%. Comparing base (82b0083) to head (83b4e60).

Files with missing lines Patch % Lines
crates/blockifier/src/versioned_constants.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                Coverage Diff                                 @@
##           yonatank/blockifier/add_syscalls_gas_costs_struct    #2501   +/-   ##
==================================================================================
  Coverage                                              71.93%   71.94%           
==================================================================================
  Files                                                    101      101           
  Lines                                                  13581    13582    +1     
  Branches                                               13581    13582    +1     
==================================================================================
+ Hits                                                    9770     9771    +1     
  Misses                                                  3382     3382           
  Partials                                                 429      429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yonatan-Starkware Yonatan-Starkware force-pushed the yonatank/blockifier/add_syscalls_gas_costs_struct branch 2 times, most recently from 44a4a6f to 82b0083 Compare December 5, 2024 16:16
@Yonatan-Starkware Yonatan-Starkware force-pushed the yonatank/blockifier/add_ecdsa_builtin_gas_cost branch from a6d9339 to 83b4e60 Compare December 5, 2024 16:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants