Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(papyrus_p2p_sync): convert state diff tests to use run_test #2511

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

ShahakShama
Copy link
Contributor

  • refactor(papyrus_p2p_sync): run_test supports all data types
  • refactor(papyrus_p2p_sync): convert state diff tests to use run_test

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.56%. Comparing base (e3165c4) to head (ef33ef5).
Report is 733 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2511       +/-   ##
===========================================
- Coverage   40.10%   26.56%   -13.55%     
===========================================
  Files          26      105       +79     
  Lines        1895    12710    +10815     
  Branches     1895    12710    +10815     
===========================================
+ Hits          760     3376     +2616     
- Misses       1100     8751     +7651     
- Partials       35      583      +548     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShahakShama ShahakShama force-pushed the shahak/p2p_sync_test_state_diff branch from ef33ef5 to 9287a94 Compare December 17, 2024 11:29
Copy link
Contributor

@eitanm-starkware eitanm-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

@ShahakShama ShahakShama merged commit 3972230 into main Dec 18, 2024
14 checks passed
@ShahakShama ShahakShama deleted the shahak/p2p_sync_test_state_diff branch December 18, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants