Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_batcher): add_sync_block on batcher client #2519

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

AlonLStarkWare
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Dec 8, 2024

@AlonLStarkWare AlonLStarkWare force-pushed the alonl/add_sync_block_function_on_batcher branch from 94d6523 to e4e298f Compare December 8, 2024 10:42
@AlonLStarkWare AlonLStarkWare changed the title feature(batcher): add_sync_block on batcher client feat(batcher): add_sync_block on batcher client Dec 8, 2024
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.47%. Comparing base (e3165c4) to head (c90b1dd).
Report is 767 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_batcher_types/src/communication.rs 0.00% 5 Missing ⚠️
crates/starknet_batcher/src/communication.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2519       +/-   ##
===========================================
+ Coverage   40.10%   77.47%   +37.37%     
===========================================
  Files          26      386      +360     
  Lines        1895    41373    +39478     
  Branches     1895    41373    +39478     
===========================================
+ Hits          760    32055    +31295     
- Misses       1100     7036     +5936     
- Partials       35     2282     +2247     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

@AlonLStarkWare AlonLStarkWare changed the title feat(batcher): add_sync_block on batcher client feat(starknet_batcher): add_sync_block on batcher client Dec 8, 2024
@AlonLStarkWare AlonLStarkWare force-pushed the alonl/add_sync_block_function_on_batcher branch from e4e298f to c90b1dd Compare December 8, 2024 12:12
Copy link
Contributor Author

@AlonLStarkWare AlonLStarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AlonLStarkWare)

@AlonLStarkWare AlonLStarkWare merged commit 0e93c0c into main Dec 9, 2024
22 checks passed
@AlonLStarkWare AlonLStarkWare deleted the alonl/add_sync_block_function_on_batcher branch December 9, 2024 12:56
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants