Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(starknet_sequencer_node): use default value for validator id #2602

Merged
merged 1 commit into from
Dec 10, 2024
Merged

chore(starknet_sequencer_node): use default value for validator id #2602

merged 1 commit into from
Dec 10, 2024

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ArniStarkware Graphite App
Copy link
Contributor Author

ArniStarkware commented Dec 9, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ArniStarkware ArniStarkware mentioned this pull request Dec 9, 2024
Merged
@ArniStarkware ArniStarkware requested a review from alonh5 December 9, 2024 18:40
@ArniStarkware ArniStarkware marked this pull request as ready for review December 9, 2024 18:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

Artifacts upload workflows:

@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.23%. Comparing base (e3165c4) to head (17e9d3c).
Report is 810 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2602       +/-   ##
===========================================
+ Coverage   40.10%   77.23%   +37.12%     
===========================================
  Files          26      392      +366     
  Lines        1895    42498    +40603     
  Branches     1895    42498    +40603     
===========================================
+ Hits          760    32823    +32063     
- Misses       1100     7381     +6281     
- Partials       35     2294     +2259

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

alonh5
alonh5 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware force-pushed the arni/config/add_config_pointer_of_sequencer_address_to_validator_id branch from 99f1cdb to 5649fa4 Compare December 10, 2024 11:31
@ArniStarkware ArniStarkware force-pushed the arni/required_params/validator_id/use_default_validator_id branch from 42b91d3 to b716e05 Compare December 10, 2024 11:32
alonh5
alonh5 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware changed the base branch from arni/config/add_config_pointer_of_sequencer_address_to_validator_id to graphite-base/2602 December 10, 2024 14:09
@ArniStarkware ArniStarkware force-pushed the arni/required_params/validator_id/use_default_validator_id branch from b716e05 to df49104 Compare December 10, 2024 14:09
@ArniStarkware ArniStarkware changed the base branch from graphite-base/2602 to main December 10, 2024 14:10
@ArniStarkware ArniStarkware force-pushed the arni/required_params/validator_id/use_default_validator_id branch from df49104 to 17e9d3c Compare December 10, 2024 14:10
ArniStarkware
ArniStarkware commented Dec 10, 2024
View reviewed changes
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware merged commit 0ad3909 into main Dec 10, 2024
23 checks passed
@ArniStarkware ArniStarkware deleted the arni/required_params/validator_id/use_default_validator_id branch December 10, 2024 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alonh5 alonh5 alonh5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArniStarkware @reviewable-StarkWare @alonh5