Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(starknet_batcher): fix clippy type complexity warning #2619

Conversation

dafnamatsry
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@dafnamatsry dafnamatsry marked this pull request as ready for review December 10, 2024 09:55
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.34%. Comparing base (e3165c4) to head (bcd6ee9).
Report is 813 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2619       +/-   ##
==========================================
- Coverage   40.10%   6.34%   -33.77%     
==========================================
  Files          26     141      +115     
  Lines        1895   17207    +15312     
  Branches     1895   17207    +15312     
==========================================
+ Hits          760    1091      +331     
- Misses       1100   16043    +14943     
- Partials       35      73       +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

@dafnamatsry dafnamatsry merged commit 2c5bef4 into main Dec 10, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants