Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configure tracing only once #2621

Merged
merged 1 commit into from
Dec 10, 2024
Merged

chore: configure tracing only once #2621

merged 1 commit into from
Dec 10, 2024

Conversation

nadin-Starkware
Copy link
Collaborator

@nadin-Starkware nadin-Starkware commented Dec 10, 2024

commit-id:ad22a238

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.62%. Comparing base (e3165c4) to head (b162c22).
Report is 801 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_sequencer_infra/src/trace_util.rs 92.30% 0 Missing and 1 partial ⚠️
crates/starknet_sequencer_node/src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2621      +/-   ##
==========================================
- Coverage   40.10%   38.62%   -1.48%     
==========================================
  Files          26      278     +252     
  Lines        1895    32172   +30277     
  Branches     1895    32172   +30277     
==========================================
+ Hits          760    12428   +11668     
- Misses       1100    18711   +17611     
- Partials       35     1033     +998     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware nadin-Starkware merged commit d92d798 into main Dec 10, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants