Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_l1_provider_types): add client #2627

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

giladchase
Copy link
Contributor

No description provided.

@giladchase giladchase requested a review from elintul December 10, 2024 12:13
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 77.06%. Comparing base (e3165c4) to head (d8251bb).
Report is 818 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_l1_provider_types/src/lib.rs 0.00% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2627       +/-   ##
===========================================
+ Coverage   40.10%   77.06%   +36.95%     
===========================================
  Files          26      394      +368     
  Lines        1895    42581    +40686     
  Branches     1895    42581    +40686     
===========================================
+ Hits          760    32814    +32054     
- Misses       1100     7472     +6372     
- Partials       35     2295     +2260     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giladchase giladchase changed the base branch from main to gilad/linker-fix December 10, 2024 13:20
@giladchase giladchase changed the base branch from gilad/linker-fix to main December 10, 2024 13:28
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @giladchase)


crates/starknet_l1_provider_types/src/lib.rs line 39 at r2 (raw file):

}

/// Serves as the mempool's shared interface. Requires `Send + Sync` to allow transferring and

Suggestion:

provider

.cargo/config.toml line 13 at r2 (raw file):

# https://github.com/rust-lang/rust/issues/39915#issuecomment-618726211
[target.x86_64-unknown-linux-gnu]
rustflags = ["-Clink-arg=-fuse-ld=lld"]

Why is this needed?

Code quote:

rustflags = ["-Clink-arg=-fuse-ld=lld"]

@giladchase giladchase force-pushed the gilad/l1-client branch 2 times, most recently from 337ae49 to d074b96 Compare December 10, 2024 14:25
@giladchase giladchase changed the base branch from main to gilad/better-linker-fix December 10, 2024 14:26
@giladchase giladchase force-pushed the gilad/better-linker-fix branch from 64514a6 to 0802b90 Compare December 10, 2024 14:44
@giladchase giladchase force-pushed the gilad/better-linker-fix branch from 0802b90 to e9ef1d3 Compare December 10, 2024 14:47
@giladchase giladchase force-pushed the gilad/better-linker-fix branch from e9ef1d3 to 054fb4e Compare December 10, 2024 14:49
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @giladchase)

@giladchase giladchase closed this Dec 11, 2024
@giladchase giladchase reopened this Dec 12, 2024
Base automatically changed from gilad/better-linker-fix to main December 12, 2024 04:05
Copy link
Contributor Author

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @elintul)


.cargo/config.toml line 13 at r2 (raw file):

Previously, elintul (Elin) wrote…

Why is this needed?

Sorry main was broken and was furiously debugging 😓 reverted this bit

Copy link
Contributor Author

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 4 files at r1, 1 of 1 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

@giladchase giladchase merged commit dc8ca7a into main Dec 12, 2024
23 checks passed
@giladchase giladchase deleted the gilad/l1-client branch December 12, 2024 05:10
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants