-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(starknet_l1_provider_types): add client #2627
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2627 +/- ##
===========================================
+ Coverage 40.10% 77.06% +36.95%
===========================================
Files 26 394 +368
Lines 1895 42581 +40686
Branches 1895 42581 +40686
===========================================
+ Hits 760 32814 +32054
- Misses 1100 7472 +6372
- Partials 35 2295 +2260 ☔ View full report in Codecov by Sentry. |
4b71c50
to
f7f22e7
Compare
f7f22e7
to
e8411df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @giladchase)
crates/starknet_l1_provider_types/src/lib.rs
line 39 at r2 (raw file):
} /// Serves as the mempool's shared interface. Requires `Send + Sync` to allow transferring and
Suggestion:
provider
.cargo/config.toml
line 13 at r2 (raw file):
# https://github.com/rust-lang/rust/issues/39915#issuecomment-618726211 [target.x86_64-unknown-linux-gnu] rustflags = ["-Clink-arg=-fuse-ld=lld"]
Why is this needed?
Code quote:
rustflags = ["-Clink-arg=-fuse-ld=lld"]
337ae49
to
d074b96
Compare
64514a6
to
0802b90
Compare
d074b96
to
ba7a46d
Compare
0802b90
to
e9ef1d3
Compare
ba7a46d
to
c0ecd1b
Compare
e9ef1d3
to
054fb4e
Compare
c0ecd1b
to
100eacb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @giladchase)
054fb4e
to
3c1eee5
Compare
100eacb
to
d9e3559
Compare
3c1eee5
to
2a9c82a
Compare
d9e3559
to
57747e4
Compare
2a9c82a
to
01f6c8a
Compare
57747e4
to
69880bc
Compare
01f6c8a
to
7d76d51
Compare
69880bc
to
9aa1869
Compare
7d76d51
to
6addc4f
Compare
9aa1869
to
74e8780
Compare
74e8780
to
eb2789e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @elintul)
.cargo/config.toml
line 13 at r2 (raw file):
Previously, elintul (Elin) wrote…
Why is this needed?
Sorry main was broken and was furiously debugging 😓 reverted this bit
eb2789e
to
d8251bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r1, 1 of 1 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @giladchase)
No description provided.