test(starknet_integration_tests): test mempool syncing in e2e flow test

[yair-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[yair-starkware]

• test(starknet_integration_tests): test mempool syncing in e2e flow test #2628 👈 (View in Graphite)
• test(starknet_integration_tests): test proposer-validator setup in flow test #2348
• fix(starknet_integration_tests): temporary fixes to make the e2e flow test pass #2591
• fix(starknet_integration_tests): fix config when creating multiple nodes #2426
• refactor(starknet_integration_tests): separate sequencer setup from test setup #2299
• test(starknet_integration_tests): test commit blocks by running multiple heights #2242
• feat(tests_integration): one to many network config #2253
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.07%. Comparing base (e3165c4) to head (6fed659).
Report is 809 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2628      +/-   ##
==========================================
- Coverage   40.10%   35.07%   -5.04%     
==========================================
  Files          26      276     +250     
  Lines        1895    32163   +30268     
  Branches     1895    32163   +30268     
==========================================
+ Hits          760    11281   +10521     
- Misses       1100    19878   +18778     
- Partials       35     1004     +969     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ShahakShama]

Reviewed 1 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @alonh5 and @yair-starkware)

---

crates/starknet_integration_tests/src/flow_test_setup.rs line 61 at r2 (raw file):

        // order to make sure the ports are not overlapping.
        let sequencer_0_consensus_manager_config = consensus_manager_configs.remove(0);
        let sequencer_0_mempool_p2p_config = mempool_p2p_configs.remove(0);

Consider converting to array with try_into and use array unpacking

let [sequencer_0_mempool_p2p_config, sequencer_1_mempool_p2p_config]: [MempoolP2pConfig; 2] = mempool_p2p_configs.try_into().unwrap();

---

crates/starknet_integration_tests/src/integration_test_setup.rs line 59 at r2 (raw file):

        let (mut consensus_manager_configs, _consensus_proposals_channels) =
            create_consensus_manager_configs_and_channels(SEQUENCER_INDICES.len());
        let mut mempool_p2p_configs =

What's happening here? Are all the configs but one dropped?

---

crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 58 at r2 (raw file):

    let sequencers = [&mock_running_system.sequencer_0, &mock_running_system.sequencer_1];
    // We use only the first sequencer's gateway to test that the mempools are syncing.

Make it clear, either by comments or (more preferrably) by code, that this is the validator

[yair-starkware]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @alonh5 and @ShahakShama)

---

crates/starknet_integration_tests/src/flow_test_setup.rs line 61 at r2 (raw file):

Previously, ShahakShama wrote…

Consider converting to array with try_into and use array unpacking

let [sequencer_0_mempool_p2p_config, sequencer_1_mempool_p2p_config]: [MempoolP2pConfig; 2] = mempool_p2p_configs.try_into().unwrap();

Done

---

crates/starknet_integration_tests/src/integration_test_setup.rs line 59 at r2 (raw file):

Previously, ShahakShama wrote…

What's happening here? Are all the configs but one dropped?

There's only 1 sequencer in the integration test for now

---

crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 58 at r2 (raw file):

Previously, ShahakShama wrote…

Make it clear, either by comments or (more preferrably) by code, that this is the validator

The proposer/validator changes each height

[ShahakShama]

Reviewed 1 of 4 files at r4, 3 of 3 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

---

crates/starknet_integration_tests/src/integration_test_setup.rs line 59 at r2 (raw file):

Previously, yair-starkware (Yair) wrote…

There's only 1 sequencer in the integration test for now

Do you want to add a TODO to add more?

[yair-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

---

crates/starknet_integration_tests/src/integration_test_setup.rs line 59 at r2 (raw file):

Previously, ShahakShama wrote…

Do you want to add a TODO to add more?

Itay's team is working on it