fix(blockifier): fix derives of GasAmount #2644
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2644 +/- ##
==========================================
+ Coverage 40.10% 46.56% +6.45%
==========================================
Files 26 32 +6
Lines 1895 2968 +1073
Branches 1895 2968 +1073
==========================================
+ Hits 760 1382 +622
- Misses 1100 1520 +420
- Partials 35 66 +31 ☔ View full report in Codecov by Sentry. |
avivg-starkware
requested review from
dorimedini-starkware and
Yoni-Starkware
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)
avivg-starkware
force-pushed
the
avivg/blockifier/gas_amount_refactor_derives
branch
from
60a1c53 to
19830f5
Compare
|
Artifacts upload workflows: |
avivg-starkware
force-pushed
the
avivg/blockifier/gas_amount_refactor_derives
branch
from
19830f5 to
5eecb98
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/gas_amount_refactor_derives
branch
from
5eecb98 to
0ba0d51
Compare
dorimedini-starkware
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.