chore(blockifier): erase block_hash_contract_address #2660
+1
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Artifacts upload workflows: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2660 +/- ##
===========================================
+ Coverage 40.10% 68.15% +28.04%
===========================================
Files 26 105 +79
Lines 1895 14311 +12416
Branches 1895 14311 +12416
===========================================
+ Hits 760 9753 +8993
- Misses 1100 4129 +3029
- Partials 35 429 +394 ☔ View full report in Codecov by Sentry. |
meship-starkware
approved these changes
Dec 15, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noaov1)
Yonatan-Starkware
force-pushed
the
yonatank/blockifier/erase_block_hash_contract_address
branch
2 times, most recently
from
b981564 to
7ef8da0
Compare
noaov1
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:
Yonatan-Starkware
force-pushed
the
yonatank/blockifier/erase_block_hash_contract_address
branch
from
7ef8da0 to
0b89278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.