chore(consensus): move the todo on ProposalFin to Matan #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @guy-starkware)
crates/papyrus_protobuf/src/consensus.rs line 89 at r1 (raw file):
pub struct ProposalFin { /// The block hash of the proposed block. /// TODO(Matan): Consider changing the content ID
The plan is to just switch this out with a signature at some point.
Suggestion:
/// TODO(Matan): Consider changing the content ID to a signature
guy-starkware
force-pushed
the
guyn/remove_proposal_fin_todo_item
branch
from
a08ec3b to
fd234ad
Compare
guy-starkware
force-pushed
the
guyn/remove_proposal_fin_todo_item
branch
from
fd234ad to
e0d95d0
Compare
matan-starkware
approved these changes
Dec 15, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This todo item seems more like something Matan would know how to do.
Need to either move it to him or remove the comment.