chore(starknet_state_sync): add default port for state sync network config #2667
Conversation
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
noamsp-starkware
force-pushed
the
noam.s/state_sync_default_network_port
branch
from
42aa82b to
0b88da7
Compare
noamsp-starkware
changed the base branch from
noam.s/remove_empty_state_sync_client
to
main
noamsp-starkware
force-pushed
the
noam.s/state_sync_default_network_port
branch
from
0b88da7 to
710529f
Compare
noamsp-starkware
force-pushed
the
noam.s/state_sync_default_network_port
branch
2 times, most recently
from
b499322 to
fec9048
Compare
noamsp-starkware
force-pushed
the
noam.s/state_sync_default_network_port
branch
from
fec9048 to
29c8421
Compare
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware)
crates/starknet_integration_tests/src/utils.rs line 282 at r1 (raw file):
pub fn create_state_sync_config( state_sync_storage_config: StorageConfig,
I think Yair updated this to be different. Please check if create_consensus_config and create_mempool_p2p_config look the same and if not update this one to look the same
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ShahakShama)
crates/starknet_integration_tests/src/utils.rs line 282 at r1 (raw file):
Previously, ShahakShama wrote…
I think Yair updated this to be different. Please check if create_consensus_config and create_mempool_p2p_config look the same and if not update this one to look the same
Spoke in private; we decided to keep this as is and fix this later once we decide to integrate a broader solution for creating the network configs
No description provided.