fix(consensus): add a safety margin so the batcher stops building early enough #2691
Conversation
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
matan-starkware
force-pushed
the
matan/consensus/mileston2/build_proposal_margin
branch
from
a23a79a to
ae3ff8f
Compare
matan-starkware
changed the title
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @matan-starkware)
a discussion (no related file):
Remove your TODO in the batcher and the division by 2 of the timeout duration and make sure the flow tests passes.
matan-starkware
force-pushed
the
matan/consensus/mileston2/build_proposal_margin
branch
from
ae3ff8f to
5825a29
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @dan-starkware)
a discussion (no related file):
Previously, alonh5 (Alon Haramati) wrote…
Remove your TODO in the batcher and the division by 2 of the timeout duration and make sure the flow tests passes.
Done and the flow test still passes.
matan-starkware
force-pushed
the
matan/consensus/mileston2/build_proposal_margin
branch
from
5825a29 to
ba860d5
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @matan-starkware)
a discussion (no related file):
Previously, matan-starkware wrote…
Done and the flow test still passes.
I see it failed in the CI
Previously, alonh5 (Alon Haramati) wrote…
Well this is annoying, it passes locally... |
matan-starkware
force-pushed
the
matan/consensus/mileston2/build_proposal_margin
branch
5 times, most recently
from
862278f to
11b9bce
Compare
…ly enough This should become configurable as part of a refactor Guy will do to the consensus configs.
matan-starkware
force-pushed
the
matan/consensus/mileston2/build_proposal_margin
branch
from
11b9bce to
89746a6
Compare
This should become configurable as part of a refactor Guy will do to the consensus configs.