fix(blockifier): typo in infinite_gas_for_vm_mode #2704
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Artifacts upload workflows: |
TzahiTaub
changed the base branch from
11-14-feat_blockifier_update_gas_and_vm_resources_computations
to
main
TzahiTaub
force-pushed
the
12-16-fix_blockifier_typo_in_infinite_gas_for_vm_mode
branch
from
2f32a5b to
03eb7b4
Compare
aner-starkware
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)
TzahiTaub
force-pushed
the
12-16-fix_blockifier_typo_in_infinite_gas_for_vm_mode
branch
from
03eb7b4 to
e612450
Compare
aner-starkware
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Reviewable status: 4 of 6 files reviewed, 3 unresolved discussions (waiting on @TzahiTaub)
crates/blockifier/src/transaction/transactions_test.rs line 263 at r2 (raw file):
}; let initial_gas = match cairo_version { CairoVersion::Cairo0 => inifite_gas_for_vm_mode(),
infinite
Code quote:
inifitecrates/blockifier/src/transaction/transactions_test.rs line 2692 at r2 (raw file):
actual_execution_info.validate_call_info.as_ref().unwrap().call.initial_gas; let expected_validate_initial_gas = match account_tracked_resource { TrackedResource::CairoSteps => VERSIONED_CONSTANTS.inifite_gas_for_vm_mode(),
infinite
Code quote:
.inifitecrates/blockifier/src/transaction/transactions_test.rs line 2818 at r2 (raw file):
actual_execution_info.validate_call_info.as_ref().unwrap().call.initial_gas; let expected_validate_initial_gas = match account_tracked_resource { TrackedResource::CairoSteps => VERSIONED_CONSTANTS.inifite_gas_for_vm_mode(),
infinite
Code quote:
inifite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.