fix(blockifier): update compiler version #2709
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 1 of 4 files at r1.
Reviewable status: 1 of 4 files reviewed, all discussions resolved
meship-starkware
force-pushed
the
meship/update_compiler_ver_to_2.9.2
branch
from
9c05b9e to
b618cf8
Compare
There was a problem hiding this comment.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @noaov1)
crates/blockifier/src/execution/syscalls/hint_processor.rs line 667 at r2 (raw file):
Hint::Core(hint) => execute_core_hint_base(vm, exec_scopes, hint, false), Hint::Starknet(hint) => self.execute_next_syscall(vm, hint), Hint::External(_) => todo!("Handle External Hints."),
This is not the right solution, but I am not sure what external hints represent and how I should handle them
Code quote:
Hint::Core(hint) => execute_core_hint_base(vm, exec_scopes, hint, false),
Hint::Starknet(hint) => self.execute_next_syscall(vm, hint),
Hint::External(_) => todo!("Handle External Hints."),
There was a problem hiding this comment.
Reviewed 2 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @meship-starkware)
crates/blockifier/src/execution/syscalls/hint_processor.rs line 665 at r2 (raw file):
let hint = hint_data.downcast_ref::<Hint>().ok_or(HintError::WrongHintData)?; match hint { Hint::Core(hint) => execute_core_hint_base(vm, exec_scopes, hint, false),
What does the false mean?
Code quote:
Hint::Core(hint) => execute_core_hint_base(vm, exec_scopes, hint, false),
meship-starkware
force-pushed
the
meship/update_compiler_ver_to_2.9.2
branch
from
b618cf8 to
001b236
Compare
There was a problem hiding this comment.
Reviewed 12 of 16 files at r3.
Reviewable status: 15 of 19 files reviewed, 2 unresolved discussions (waiting on @noaov1)
There was a problem hiding this comment.
Reviewable status: 15 of 19 files reviewed, 4 unresolved discussions (waiting on @noaov1)
crates/blockifier/src/execution/syscalls/hint_processor.rs line 665 at r2 (raw file):
Previously, noaov1 (Noa Oved) wrote…
What does the
falsemean?
I am not sure this is the comment in the Cairo compiler:
/// Avoid allocating memory segments so that the finalization of the segment arena may not occur.
So, to my understanding, false here means we do not avoid allocating memory segments, but I am not sure I will ask someone from the compiler team.
crates/blockifier/src/transaction/transactions_test.rs line 2438 at r3 (raw file):
computation: ComputationResources { vm_resources: expected_execution_resources, sierra_gas: gas_consumed.into(),
The cosmetic change for Cllipy does not relate to the Cairo version update.
Code quote:
sierra_gas: gas_consumed.into(),crates/blockifier/src/execution/syscalls/syscall_tests/keccak.rs line 29 at r3 (raw file):
pretty_assertions::assert_eq!( entry_point_call.execute_directly(&mut state).unwrap().execution, CallExecution { gas_consumed: 254240, ..CallExecution::from_retdata(retdata![]) }
@ilyalesokhin-starkware, Can you make sure this gas change looks logical after the compiler version update?
Code quote:
CallExecution { gas_consumed: 254240, ..CallExecution::from_retdata(retdata![]) }
meship-starkware
force-pushed
the
meship/update_compiler_ver_to_2.9.2
branch
from
001b236 to
c54523a
Compare
There was a problem hiding this comment.
Reviewable status: 15 of 19 files reviewed, 4 unresolved discussions (waiting on @noaov1)
crates/blockifier/src/execution/syscalls/hint_processor.rs line 665 at r2 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
I am not sure this is the comment in the Cairo compiler:
/// Avoid allocating memory segments so that the finalization of the segment arena may not occur.
So, to my understanding, false here means we do not avoid allocating memory segments, but I am not sure I will ask someone from the compiler team.
Talked with Ori Ziv, and I understood correctly but as the segment arena finalization is only relevant to the proofs, so we do want to avoid allocating temporary segments
crates/blockifier/src/execution/syscalls/hint_processor.rs line 667 at r2 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
This is not the right solution, but I am not sure what external hints represent and how I should handle them
The sequencer shouldn't get external hints
|
Benchmark movements: |
There was a problem hiding this comment.
Reviewed 3 of 16 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions
meship-starkware
force-pushed
the
meship/update_compiler_ver_to_2.9.2
branch
from
c54523a to
4955476
Compare
There was a problem hiding this comment.
Reviewed 1 of 4 files at r5.
Reviewable status: 16 of 19 files reviewed, 2 unresolved discussions (waiting on @noaov1)
There was a problem hiding this comment.
Reviewed 1 of 4 files at r5.
Reviewable status: 17 of 19 files reviewed, 2 unresolved discussions (waiting on @noaov1)
There was a problem hiding this comment.
Reviewed 1 of 4 files at r5.
Reviewable status: 18 of 19 files reviewed, 2 unresolved discussions (waiting on @noaov1)
|
Previously, meship-starkware (Meshi Peled) wrote…
Looks fine |
|
Benchmark movements: |
There was a problem hiding this comment.
Reviewed 4 of 16 files at r3, 1 of 4 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)
No description provided.