Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_class_manager_types): add crate #2713

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

elintul
Copy link
Collaborator

@elintul elintul commented Dec 17, 2024

No description provided.

@elintul elintul requested a review from giladchase December 17, 2024 09:26
@reviewable-StarkWare
Copy link

This change is Reviewable

@elintul elintul force-pushed the elin/contract-manager/add-types-crate branch 3 times, most recently from fa2cb8d to 7380df7 Compare December 17, 2024 15:46
@elintul elintul changed the title feat(starknet_contract_manager_types): add crate feat(starknet_class_manager_types): add crate Dec 17, 2024
Copy link
Contributor

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @elintul)


crates/starknet_class_manager_types/src/lib.rs line 11 at r1 (raw file):

use thiserror::Error;

pub type ClassManagerResult<T> = Result<T, ClassManagerError>;

🎩 💁‍♂️

Code quote:

ClassManager

Copy link
Collaborator Author

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @elintul)


crates/starknet_class_manager_types/src/lib.rs line 11 at r1 (raw file):

Previously, giladchase wrote…

🎩 💁‍♂️

❤️

@elintul elintul force-pushed the elin/contract-manager/add-types-crate branch from 7380df7 to 461d9b3 Compare December 18, 2024 08:52
Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.034 ms 35.144 ms 35.272 ms]
change: [+1.0939% +1.4859% +1.8493%] (p = 0.00 < 0.05)
Performance has regressed.
Found 8 outliers among 100 measurements (8.00%)
2 (2.00%) high mild
6 (6.00%) high severe

Copy link
Contributor

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @elintul)

Copy link
Contributor

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @elintul)

@elintul elintul merged commit dd0473f into main Dec 18, 2024
21 checks passed
@elintul elintul deleted the elin/contract-manager/add-types-crate branch December 18, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants