-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(consensus): add CentralStateDiff object in the aerospike format #2715
base: main
Are you sure you want to change the base?
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Artifacts upload workflows: |
4986040
to
8eac87b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @Yael-Starkware)
crates/sequencing/papyrus_consensus_orchestrator/src/lib.rs
line 5 at r1 (raw file):
//! Implements the consensus context - the interface for consensus to call out to the node. mod central_communication;
move this module to cende when merged
crates/sequencing/papyrus_consensus_orchestrator/src/central_communication/central_objects_test.rs
line 73 at r1 (raw file):
let python_json: Value = serde_json::from_str(&python_json_string).unwrap(); assert_eq!(rust_json, python_json,);
we should compare here string representation of the JSON and not the JsonValue
object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @DvirYo-starkware)
crates/sequencing/papyrus_consensus_orchestrator/src/central_communication/central_objects_test.rs
line 73 at r1 (raw file):
Previously, DvirYo-starkware wrote…
we should compare here string representation of the JSON and not the
JsonValue
object
The strings are not the same due to spaces and \n chars.
what is the problem with comparing jsonValue?
No description provided.