feat(starknet_integration_tests): pass test scenarios from the test body

[yair-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[yair-starkware]

• wip #2807
• test(starknet_integration_tests): fund contract address for deployment #2806
• feat(mempool_test_utils): util to generate deploy account txs #2805
• feat(mempool_test_utils): utility to create transfer txs #2804
• fix(mempool_test_utils): remove unnecessary pub #2803
• feat(mempool_test_utils): register accounts as deployed or undeployed #2802
• refactor(mempool_test_utils): add non mut account_with_id, rename previous implementation #2801
• feat(starknet_integration_tests): pass test scenarios from the test body #2724 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[graphite-app]

Graphite Automations

"Yair - Auto-assign" took an action on this PR • (12/17/24)

1 assignee was added to this PR based on Yair's automation.

[alonh5]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Itay-Tsabary-Starkware and @yair-starkware)

---

crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 70 at r1 (raw file):

    let test_tx_hashes_scenarios =
        [test_tx_hashes_for_integration_test, test_tx_hashes_for_integration_test];

Why do you need these?

Code quote:

    let create_rpc_txs_scenarios =
        [create_txs_for_integration_test, create_txs_for_integration_test];

    let test_tx_hashes_scenarios =
        [test_tx_hashes_for_integration_test, test_tx_hashes_for_integration_test];

---

crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 73 at r1 (raw file):

    // Build multiple heights to ensure heights are committed.
    for (height, expected_content_id, create_rpc_txs_fn, test_tx_hashes_fn) in itertools::izip!(

I think actually it is important to assert they are all the same length. Otherwise some of the test might be missing without us noticing

---

crates/starknet_integration_tests/src/utils.rs line 207 at r1 (raw file):

    create_rpc_txs_fn: impl Fn(&mut MultiAccountTransactionGenerator) -> Vec<RpcTransaction>,
    send_rpc_tx_fn: &'a mut dyn FnMut(RpcTransaction) -> Fut,
    test_tx_hashes_fn: impl Fn(&[TransactionHash]) -> Vec<TransactionHash>,

Should these two be coupled?

Code quote:

    create_rpc_txs_fn: impl Fn(&mut MultiAccountTransactionGenerator) -> Vec<RpcTransaction>,
    send_rpc_tx_fn: &'a mut dyn FnMut(RpcTransaction) -> Fut,
    test_tx_hashes_fn: impl Fn(&[TransactionHash]) -> Vec<TransactionHash>,

[yair-starkware]

Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @alonh5 and @Itay-Tsabary-Starkware)

---

crates/starknet_integration_tests/src/utils.rs line 207 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Should these two be coupled?

WDYM?

---

crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 70 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Why do you need these?

When adding deploy_account I need different test txs

---

crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 73 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

I think actually it is important to assert they are all the same length. Otherwise some of the test might be missing without us noticing

Done.

[alonh5]

Reviewed 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware and @yair-starkware)

---

crates/starknet_integration_tests/src/utils.rs line 207 at r1 (raw file):

Previously, yair-starkware (Yair) wrote…

WDYM?

create_rpc_txs_fn and test_tx_hashes_fn.

[yair-starkware]

crates/starknet_integration_tests/src/utils.rs line 207 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

create_rpc_txs_fn and test_tx_hashes_fn.

Added a TODO because it is a bit tricky task