-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(blockifier): min compiler version for sierra gas type #2752
base: aviv/get_versioned_contract_class_in_papyrus_execution
Are you sure you want to change the base?
Conversation
01f3e55
to
f34812f
Compare
1683c47
to
4758e0e
Compare
Artifacts upload workflows: |
f34812f
to
26d288a
Compare
4758e0e
to
5e89fc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 27 of 27 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @noaov1, and @TzahiTaub)
crates/blockifier/src/execution/contract_class.rs
line 312 at r1 (raw file):
pub fn try_from_json_string(raw_contract_class: &str) -> Result<CompiledClassV1, ProgramError> { let casm_contract_class: CasmContractClass = serde_json::from_str(raw_contract_class)?; let sierra_version = SierraVersion::default();
is this ok...? where is try_from_json_string
used?
Code quote:
let sierra_version = SierraVersion::default();
26d288a
to
dbcfb50
Compare
5e89fc0
to
694bb8f
Compare
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @noaov1, and @TzahiTaub)
No description provided.