Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier): min compiler version for sierra gas type #2752

Open
wants to merge 1 commit into
base: aviv/get_versioned_contract_class_in_papyrus_execution
Choose a base branch
from

Conversation

AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_versioned_contract_class_in_papyrus_execution branch from 01f3e55 to f34812f Compare December 18, 2024 13:52
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_blockifier_contract_class branch from 1683c47 to 4758e0e Compare December 18, 2024 13:52
Copy link

github-actions bot commented Dec 18, 2024

@AvivYossef-starkware AvivYossef-starkware marked this pull request as ready for review December 18, 2024 13:59
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_versioned_contract_class_in_papyrus_execution branch from f34812f to 26d288a Compare December 18, 2024 14:03
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_blockifier_contract_class branch from 4758e0e to 5e89fc0 Compare December 18, 2024 14:03
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 27 of 27 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @noaov1, and @TzahiTaub)


crates/blockifier/src/execution/contract_class.rs line 312 at r1 (raw file):

    pub fn try_from_json_string(raw_contract_class: &str) -> Result<CompiledClassV1, ProgramError> {
        let casm_contract_class: CasmContractClass = serde_json::from_str(raw_contract_class)?;
        let sierra_version = SierraVersion::default();

is this ok...? where is try_from_json_string used?

Code quote:

let sierra_version = SierraVersion::default();

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_versioned_contract_class_in_papyrus_execution branch from 26d288a to dbcfb50 Compare December 18, 2024 14:57
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_blockifier_contract_class branch from 5e89fc0 to 694bb8f Compare December 18, 2024 14:58
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.852 ms 33.890 ms 33.931 ms]
change: [-5.0047% -3.5249% -2.2314%] (p = 0.00 < 0.05)
Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
3 (3.00%) low severe
1 (1.00%) low mild
4 (4.00%) high mild
4 (4.00%) high severe

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @noaov1, and @TzahiTaub)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants