Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmp #2799

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tmp #2799

wants to merge 1 commit into from

Conversation

giladchase
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@giladchase giladchase force-pushed the gilad/try-env branch 13 times, most recently from 1f2bf5e to b295955 Compare December 19, 2024 07:59
- Install nightly through moonrepo, so it'll be cached.
- Only install nightly when necessary.
- Always run rustfmt on --all for both push/pull.
It doesn't compile anything and runs on `--all` in a few seconds.

Benchmark: seems to reduce time from ~15 seconds to ~5 seconds, and
logs indeed show that nothing is installed, only rustfmt is run.

Unrelated: remove clippy/rustfmt from the components in
rust-toolchain.toml, when using the `default` profile they are already
included.
@giladchase giladchase changed the base branch from gilad/rustfmt-ci-refactor to main December 19, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants