-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add disabled function to ComponentConfig #2867
Conversation
0458bfc
to
f1fa7c4
Compare
979ce62
to
12aed6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @nadin-Starkware)
crates/starknet_integration_tests/src/config_utils.rs
line 122 at r1 (raw file):
..ComponentConfig::default() } }
Please format this function to be as get_http_only_component_config
Code quote:
pub async fn get_non_http_component_config(gateway_socket: SocketAddr) -> ComponentConfig {
ComponentConfig {
http_server: ActiveComponentExecutionConfig::disabled(),
monitoring_endpoint: Default::default(),
gateway: ReactiveComponentExecutionConfig::local_with_remote_enabled(gateway_socket),
..ComponentConfig::default()
}
}
crates/starknet_integration_tests/src/config_utils.rs
line 124 at r1 (raw file):
} pub async fn get_remote_flow_test_config() -> Vec<ComponentConfig> {
Is this still for the flow
test? If not, please rename.
Code quote:
get_remote_flow_test_config()
f1fa7c4
to
5441210
Compare
12aed6d
to
210647f
Compare
5441210
to
4263983
Compare
210647f
to
6952eb3
Compare
7f35f91
to
f62beed
Compare
6952eb3
to
e50fb52
Compare
f62beed
to
bd2f3c0
Compare
dd1004f
to
6c22bb5
Compare
4790ad2
to
8488fa1
Compare
6c22bb5
to
47ab72c
Compare
8488fa1
to
a2ea04b
Compare
47ab72c
to
c004c33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)
crates/starknet_integration_tests/src/config_utils.rs
line 122 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Please format this function to be as
get_http_only_component_config
Default
doesn't provide mutable fields for assignment after creation.
crates/starknet_integration_tests/src/config_utils.rs
line 124 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Is this still for the
flow
test? If not, please rename.
Done.
a2ea04b
to
0687470
Compare
c004c33
to
e367fbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @nadin-Starkware)
crates/starknet_integration_tests/src/config_utils.rs
line 122 at r1 (raw file):
Previously, nadin-Starkware (Nadin Jbara) wrote…
Default
doesn't provide mutable fields for assignment after creation.
let mut config = ComponentConfig::Default()
config.X = Y
That doesn't work?
e367fbf
to
ed7bbb3
Compare
0687470
to
7f75c0f
Compare
commit-id:fe5285a8
commit-id:9673c1ca
ed7bbb3
to
af74334
Compare
7f75c0f
to
8a3052f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)
crates/starknet_integration_tests/src/config_utils.rs
line 122 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
let mut config = ComponentConfig::Default() config.X = Y
That doesn't work?
Nope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r4, all commit messages.
Reviewable status: 2 of 3 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
commit-id:9673c1ca
Stack: