Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge main-v0.13.2 into main #327

Merged
merged 11 commits into from
Aug 5, 2024
Merged

Merge main-v0.13.2 into main #327

merged 11 commits into from
Aug 5, 2024

Conversation

Yoni-Starkware
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware commented Aug 5, 2024 •
edited by alon-dotan-starkware
Loading

This change is Reviewable

dorimedini-starkware and others added 10 commits August 1, 2024 14:18
@dorimedini-starkware
feat(ci): build native blockifier artifacts on every merge (#248)
82e6edf 
Signed-off-by: Dori Medini <dori@starkware.co>
@alon-dotan-starkware
chore: add merge gate keeper (#253)
acad650
@AvivYossef-starkware
refactor: make external tests generic (#140)
8844718
@dorimedini-starkware
chore(ci): move papyrus_config dep to root toml (#255)
aa57ea3
@alon-dotan-starkware
chore(ci): fix gatekeeper config (#310)
87e6d3f
@AvivYossef-starkware
refactor: tree hash function impl (#156)
6de6b81 
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/starkware-libs/sequencer/156)
<!-- Reviewable:end -->
@AvivYossef-starkware
refactor: committer node index (#160)
516f0ce 
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/starkware-libs/sequencer/160)
<!-- Reviewable:end -->
@AvivYossef-starkware
refactor: remove async fun from create (#167)
ff11dd7 
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/starkware-libs/sequencer/167)
<!-- Reviewable:end -->
@Yoni-Starkware
chore: bump compiler to 2.7.0 and vm to 1.0.0-rc6 (#304)
40b9492
@Yoni-Starkware
chore: merge branch main-v0.13.2 into main (with conflicts)
891d25e
@Yoni-Starkware
Copy link
Collaborator Author

Src Dst .github/workflows/main.yml

Yoni-Starkware
Yoni-Starkware commented Aug 5, 2024
View reviewed changes
Copy link
Collaborator Author

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 6 of 7 files at r3, 9 of 14 files at r4, 3 of 3 files at r6, 9 of 9 files at r7, 1 of 1 files at r8, 5 of 7 files at r9, 7 of 7 files at r10, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [29.314 ms 29.368 ms 29.428 ms]
change: [+1.0266% +1.8288% +2.3596%] (p = 0.00 < 0.05)
Performance has regressed.
Found 11 outliers among 100 measurements (11.00%)
9 (9.00%) high mild
2 (2.00%) high severe

@codecov Codecov
Copy link

codecov bot commented Aug 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 69.44444% with 11 lines in your changes missing coverage. Please review.

Project coverage is 76.78%. Comparing base (fe93a3b) to head (15f7982).
Report is 3 commits behind head on main.

Files Patch % Lines
crates/committer/src/block_committer/commit.rs 55.55% 4 Missing ⚠️
crates/committer/src/block_committer/input.rs 81.81% 2 Missing ⚠️
...ter/src/patricia_merkle_tree/filled_tree/forest.rs 0.00% 2 Missing ⚠️
...rkle_tree/updated_skeleton_tree/skeleton_forest.rs 0.00% 2 Missing ⚠️
.../blockifier/src/execution/entry_point_execution.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
- Coverage   76.89%   76.78%   -0.12%     
==========================================
  Files         316      318       +2     
  Lines       34504    34533      +29     
  Branches    34504    34533      +29     
==========================================
- Hits        26532    26515      -17     
- Misses       5687     5730      +43     
- Partials     2285     2288       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yoni-Starkware Yoni-Starkware self-assigned this Aug 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [30.172 ms 30.288 ms 30.436 ms]
change: [+5.1796% +5.6504% +6.2336%] (p = 0.00 < 0.05)
Performance has regressed.
Found 6 outliers among 100 measurements (6.00%)
3 (3.00%) high mild
3 (3.00%) high severe

dorimedini-starkware
dorimedini-starkware approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r11, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

@Yoni-Starkware Yoni-Starkware merged commit fa2ecf4 into main Aug 5, 2024
27 checks passed
@Yoni-Starkware Yoni-Starkware deleted the yoni/merge-main-v0.13.2-into-main-1722857090 branch August 5, 2024 12:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dorimedini-starkware dorimedini-starkware dorimedini-starkware approved these changes

Assignees

@Yoni-Starkware Yoni-Starkware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yoni-Starkware @dorimedini-starkware @alon-dotan-starkware @AvivYossef-starkware