-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): use large-runners in order to increase concurrency #333
chore(ci): use large-runners in order to increase concurrency #333
Conversation
307a923
to
7bce78b
Compare
Benchmark movements: |
7bce78b
to
1032425
Compare
Benchmark movements: |
Benchmark movements: |
1194486
to
cb98842
Compare
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 14 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alon-dotan-starkware)
a discussion (no related file):
py side PR?
.github/workflows/papyrus_nightly-tests.yml
line 16 at r2 (raw file):
uses: ./.github/workflows/papyrus_nightly-tests-call.yml with: os: starkware-ubuntu-latest-small
why small?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)
a discussion (no related file):
Previously, dorimedini-starkware wrote…
py side PR?
https://github.com/starkware-industries/starkware/pull/35690
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)
.github/workflows/papyrus_nightly-tests.yml
line 16 at r2 (raw file):
Previously, dorimedini-starkware wrote…
why small?
Try to reduce costs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alon-dotan-starkware)
This change is