Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use large-runners in order to increase concurrency #333

Merged

Conversation

alon-dotan-starkware
Copy link
Contributor

@alon-dotan-starkware alon-dotan-starkware commented Aug 5, 2024

This change is Reviewable

@alon-dotan-starkware alon-dotan-starkware force-pushed the alon.dotan/main-v0.13.2/ci/large-runners branch from 307a923 to 7bce78b Compare August 5, 2024 21:03
Copy link

github-actions bot commented Aug 5, 2024

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.069 ms 66.140 ms 66.219 ms]
change: [-6.3817% -4.3231% -2.5703%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe

@alon-dotan-starkware alon-dotan-starkware force-pushed the alon.dotan/main-v0.13.2/ci/large-runners branch from 7bce78b to 1032425 Compare August 5, 2024 21:14
Copy link

github-actions bot commented Aug 5, 2024

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.899 ms 65.984 ms 66.092 ms]
change: [-10.848% -6.6865% -2.9781%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
5 (5.00%) high mild
2 (2.00%) high severe

Copy link

github-actions bot commented Aug 6, 2024

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.677 ms 66.206 ms 66.956 ms]
change: [-9.1056% -5.6150% -2.4733%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe

@alon-dotan-starkware alon-dotan-starkware force-pushed the alon.dotan/main-v0.13.2/ci/large-runners branch from 1194486 to cb98842 Compare August 6, 2024 07:40
Copy link

github-actions bot commented Aug 6, 2024

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.186 ms 66.257 ms 66.344 ms]
change: [-10.263% -6.9682% -3.9917%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 14 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alon-dotan-starkware)

a discussion (no related file):
py side PR?



.github/workflows/papyrus_nightly-tests.yml line 16 at r2 (raw file):

    uses: ./.github/workflows/papyrus_nightly-tests-call.yml
    with:
      os: starkware-ubuntu-latest-small

why small?

Copy link
Contributor Author

@alon-dotan-starkware alon-dotan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)

a discussion (no related file):

Previously, dorimedini-starkware wrote…

py side PR?

https://github.com/starkware-industries/starkware/pull/35690


Copy link
Contributor Author

@alon-dotan-starkware alon-dotan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)


.github/workflows/papyrus_nightly-tests.yml line 16 at r2 (raw file):

Previously, dorimedini-starkware wrote…

why small?

Try to reduce costs...

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alon-dotan-starkware)

@alon-dotan-starkware alon-dotan-starkware merged commit 3c970fd into main-v0.13.2 Aug 6, 2024
28 checks passed
@alon-dotan-starkware alon-dotan-starkware deleted the alon.dotan/main-v0.13.2/ci/large-runners branch August 6, 2024 09:38
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants