Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier): rename transaction_receipt t… #336

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Yoni-Starkware
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware commented Aug 6, 2024

…o receipt


This change is Reviewable

@Yoni-Starkware Yoni-Starkware force-pushed the yoni/blockifier/tx-receipt branch from 7c59a96 to 51e436a Compare August 6, 2024 09:34
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 60.71429% with 11 lines in your changes missing coverage. Please review.

Project coverage is 76.92%. Comparing base (fdff7db) to head (51e436a).
Report is 14 commits behind head on main.

Files Patch % Lines
crates/papyrus_execution/src/objects.rs 58.82% 1 Missing and 6 partials ⚠️
crates/native_blockifier/src/py_block_executor.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   76.77%   76.92%   +0.15%     
==========================================
  Files         318      318              
  Lines       34565    34700     +135     
  Branches    34565    34700     +135     
==========================================
+ Hits        26536    26693     +157     
- Misses       5739     5741       +2     
+ Partials     2290     2266      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

@Yoni-Starkware Yoni-Starkware changed the title refactor(blockifier, papyrus_execution): rename transaction_receipt t… refactor(blockifier): rename transaction_receipt t… Aug 6, 2024
@Yoni-Starkware Yoni-Starkware merged commit 92d201d into main Aug 6, 2024
42 of 44 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants